Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breakfix: Fix Example 2 of Procedure Loading, reading state for non-deleted grants #104

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

DerekTBrown
Copy link

What does this PR do?

  • Per comment here adds a regression test for "Example 2" way of defining procedures, and fixes the behavior.

mysql/resource_grant.go Outdated Show resolved Hide resolved
@DerekTBrown DerekTBrown marked this pull request as ready for review January 23, 2024 20:20
@DerekTBrown DerekTBrown requested a review from petoju January 23, 2024 20:20
mysql/resource_grant.go Outdated Show resolved Hide resolved
@DerekTBrown DerekTBrown changed the title fix example 2 breakfix: Fix Example 2 of Procedure Loading, Reading State for non-deleted grants Jan 24, 2024
@DerekTBrown DerekTBrown changed the title breakfix: Fix Example 2 of Procedure Loading, Reading State for non-deleted grants breakfix: Fix Example 2 of Procedure Loading, reading state for non-deleted grants Jan 24, 2024
@DerekTBrown DerekTBrown force-pushed the derektbrown_fix_example_2 branch 3 times, most recently from cbf9345 to be4dc9e Compare January 24, 2024 09:21
mysql/resource_grant.go Outdated Show resolved Hide resolved
mysql/resource_grant.go Show resolved Hide resolved
mysql/resource_grant.go Outdated Show resolved Hide resolved
@petoju
Copy link
Owner

petoju commented Jan 25, 2024

BTW it still writes here "This branch has conflicts that must be resolved". Could you please rebase against the latest master?

@petoju
Copy link
Owner

petoju commented Jan 26, 2024

Ok, I tested it, it looks good, code looks good - there are just merge conflicts for you to resolve

@DerekTBrown DerekTBrown force-pushed the derektbrown_fix_example_2 branch from 4698a3a to 28b4499 Compare January 29, 2024 18:23
Copy link
Owner

@petoju petoju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good

@petoju petoju merged commit 1d8c642 into petoju:master Jan 29, 2024
13 checks passed
@petoju
Copy link
Owner

petoju commented Jan 29, 2024

Released in v3.0.46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants