forked from hashicorp/terraform-provider-mysql
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breakfix: Fix Example 2 of Procedure Loading, reading state for non-deleted grants #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petoju
reviewed
Jan 23, 2024
petoju
reviewed
Jan 23, 2024
DerekTBrown
changed the title
fix example 2
breakfix: Fix Example 2 of Procedure Loading, Reading State for non-deleted grants
Jan 24, 2024
DerekTBrown
changed the title
breakfix: Fix Example 2 of Procedure Loading, Reading State for non-deleted grants
breakfix: Fix Example 2 of Procedure Loading, reading state for non-deleted grants
Jan 24, 2024
DerekTBrown
force-pushed
the
derektbrown_fix_example_2
branch
3 times, most recently
from
January 24, 2024 09:21
cbf9345
to
be4dc9e
Compare
petoju
reviewed
Jan 24, 2024
BTW it still writes here "This branch has conflicts that must be resolved". Could you please rebase against the latest master? |
Ok, I tested it, it looks good, code looks good - there are just merge conflicts for you to resolve |
This reverts commit 79b4e96.
DerekTBrown
force-pushed
the
derektbrown_fix_example_2
branch
from
January 29, 2024 18:23
4698a3a
to
28b4499
Compare
petoju
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it looks good
Released in v3.0.46 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?