Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data.tables documentation #44

Merged
merged 2 commits into from
Nov 7, 2022

Conversation

Ken-Sumi1019
Copy link

@Ken-Sumi1019 Ken-Sumi1019 commented Nov 6, 2022

Because tabels is implemented but not documented.

@Ken-Sumi1019 Ken-Sumi1019 marked this pull request as ready for review November 6, 2022 09:20
@Ken-Sumi1019 Ken-Sumi1019 changed the title Add table data source documentation Add data.tables documentation Nov 6, 2022
Copy link
Owner

@petoju petoju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it mostly looks good - I have only some grammar issues / extra newline / type.

website/docs/d/tables.html.markdown Outdated Show resolved Hide resolved
website/docs/d/tables.html.markdown Outdated Show resolved Hide resolved
website/docs/d/tables.html.markdown Outdated Show resolved Hide resolved
@Ken-Sumi1019
Copy link
Author

Thanks for your review.
I have corrected everything.

@petoju
Copy link
Owner

petoju commented Nov 7, 2022

Thanks for the fixes.

@petoju petoju merged commit 9065753 into petoju:master Nov 7, 2022
@Ken-Sumi1019 Ken-Sumi1019 deleted the feature/add-tables-doc branch November 7, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants