-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for Amazon RDS MySQL config #60
Conversation
Feat binlog retention
docs: add mysql_retention_period docs for terraform registry
* feat: replace binlog resource for RDS config resource * chore: add mysq_rds_config read, update and import acctest
Thanks for the PR. There are some things to resolve, but generally, it looks good. |
Thanks for considering this contribution and for you review. I think I have the requested changes fixed by 0dc96e0 . Let me know if looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, we're getting there.
Once you address my comments, I'll spend my 10 cents to get RDS to run tests on that. Hopefully that will work.
I think I have all addressed. My comment about the "+rds" or empty string got lost: I thought about creating a generic function that would return metadata do the Version (https://pkg.go.dev/github.com/hashicorp/go-version#section-readme). Possibly could be used by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase against my latest master and really try running the tests, if you can. Because some tests do not run as they should.
You can skip RDS in some of the tests - it makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your changes!
I release provider version 3.0.30 that includes this PR. |
That's great news!! I am very happy to contribute :-) |
Implements a new resource called
mysql_rds_config
that handles Amazons RDS MySQL config parameters that otherwise could only be configured using alocal-exec
approach. Discussion here #56