feat: add retain old password support #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petoju
requested changes
Sep 12, 2023
Kiliandeca
force-pushed
the
feat/retain-old-password
branch
from
f782582 to
5cb0255
Compare
|
Thanks for your quick review and guidance on how to implement the tests. Let me know if there are still things you want me to improve. |
|
Released in v3.0.42 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋, this PR introduce the possibility of retaining the old password when the password change as described in #17.
I would like to add a test but I'm not very fluent in Go and unless I'm mistaken there are currently no test that check if the user password works from which I could copy/inspire. Any feedback or advice is very welcome 🙏