[ROCm] Enable Tiled layout extension and minor changes to setup #3
Conversation
There was a problem hiding this comment.
@lcskrishna I am seeing env issue with latest pytorch docker. Did I miss anything?
To be more specific, the following bf16 types are not converted.
("__nv_bfloat16", ("__hip_bfloat16", CONV_TYPE, API_RUNTIME)),
("__nv_bfloat162", ("__hip_bfloat162", CONV_TYPE, API_RUNTIME)),
| __nv_bfloat162 scale2 = __bfloat162bfloat162(pSZ[0]); | ||
| __nv_bfloat162 zero2 = __bfloat162bfloat162(pSZ[1]); | ||
| if (scales_and_zeros) { | ||
| const auto&sz = *scales_and_zeros; |
There was a problem hiding this comment.
@lcskrishna This change fixes compilation for me, please refer to my scratch space : https://github.com/petrex/ao/tree/rocm_tensor_tile
There was a problem hiding this comment.
Thanks @petrex for taking a look. I will update it accordingly.
Ah!! forgot to mention, use pytorch nightly. This seems to work after PT 2.5. |
Yes let's seperate that out and do it later. |
|
could you share the docker image you are using? and maybe a little clean up/lint on the code before merge. thx |
No description provided.