Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bugs in overviews #104

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Fixing bugs in overviews #104

merged 2 commits into from
Jun 12, 2024

Conversation

afraniomelo
Copy link
Collaborator

By creating this pull request, I confirm that I have read and fully accept and agree with one of the Petrobras' Contributor License Agreements (CLAs):

Our CLAs are based on the Apache Software Foundation's CLAs:

@ricardoevvargas
Copy link
Collaborator

Hi, @afraniomelo. Thanks for this contribution! Now the community can run the overview codes you've designed to evaluate results and gain insights without having to make adjustments.

However, although the identified bugs have been eliminated, we still need to integrate the code from these overviews more closely into the 3W toolkit and/or 3W dataset. Methods, constants and settings useful for other overviews and/or experimentations can be incorporated into the 3W toolkit and/or 3W dataset. And what already exists in the 3W toolkit and 3W dataset should preferably be used. For examples, in your overviews there are:

  1. Unnecessary definitions for "tags" and "names", since these constants are defined in dataset.ini. It is recommended to consult this file, as in the next versions of the 3W dataset these settings may be evolved.
  2. CSV files are imported with pd.read_csv, and 3W tookit already has a function for loading instances (load_instance). Again, the structure of the 3W dataset may change and direct consumption of the csv files may stop working.

How about you and others in the community working to evolve these overviews, the 3W dataset and the 3W toolkit? This kind of contribution will be greatly appreciated. For more details on submitting contributions, please consult our guide at https://github.com/petrobras/3W/blob/main/CONTRIBUTING.md.

Once again, thanks for this contribution.

@ricardoevvargas ricardoevvargas merged commit b420a1b into main Jun 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants