Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add application trigger #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add application trigger #27

wants to merge 1 commit into from

Conversation

aliask
Copy link

@aliask aliask commented May 31, 2020

This pull requests adds the functionality to switch power plans when an application starts or stops.

New configuration items have been added for:

  • Application process name (e.g. 'notepad.exe')
  • Power plan to switch to at application start
  • Power plan to switch to at application exit

Note that this functionality requires that the app be given administrator privileges.

@petrroll
Copy link
Owner

Hi!
First off, amazing work! Happy to see that my code is still useful after all this time. Unfortunately I'll not be merging the PR at the moment for two reasons:

  1. I don't feel like making the app admin only as I generally don't like giving admin permissions to apps. Also, I'm not quite sure how the requireAdministrator plays together with MSIX/AppX "container" / if it's possible to have based-on-settings admin privileges, etc.
  2. As of right now I don't have the time (Not in active development (since Sep2017) #23) to rework the packaging pipeline so even if 1) wasn't an issue I'd still not build a publish a new version.

Given that I see little reason to merge this in master. If someone wants to build their own version with app trigger support they can just just clone your fork and use it.


Alternatively, I'd be happy to create a separate branch for this feature on this repo and you can merge into that one. I'll remember to keep it in sync with master if I ever come back to developing this.

I hope you understand. :)

@aliask
Copy link
Author

aliask commented May 31, 2020 via email

@MilanPutnik
Copy link

Just dropped by and wanted to say that you actually have (literally) a whole fanbase of at least 50 IT professionals and esports players - who use this small addon since its inception, across various CPU platforms that came along, trough all of the W10 iterations...up until now. :-)
We all would love to see an update from you - at least a symbolic zero point one. ;-P
Stay well and all the best !

@petrroll
Copy link
Owner

Hi, @MilanPutnik thanks for the kind words! I'll think about it :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants