-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add application trigger #27
base: master
Are you sure you want to change the base?
Conversation
Hi!
Given that I see little reason to merge this in master. If someone wants to build their own version with app trigger support they can just just clone your fork and use it. Alternatively, I'd be happy to create a separate branch for this feature on this repo and you can merge into that one. I'll remember to keep it in sync with master if I ever come back to developing this. I hope you understand. :) |
Hi Petr,
I completely get it - I had the same annoyance when I found out it would
require admin access too. To be honest I just wanted this feature myself
and had some time on my Sunday, and thought I may as well share the results.
Hopefully someone finds it useful!
Cheers,
Will
…On Sun, 31 May 2020, 10:18 pm Petr Houška, ***@***.***> wrote:
Hi!
First off, amazing work! Happy to see that my code is still useful after
all this time. Unfortunately I'll not be merging the PR at the moment for
two reasons:
1. I don't feel like making the app admin only as I generally don't
like giving admin permissions to apps. Also, I'm not quite sure how the
requireAdministrator plays together with MSIX/AppX *"container"* / if
it's possible to have based-on-settings admin privileges, etc.
2. As of right now I don't have the time (#23
<#23>) to rework the
packaging pipeline so even if 1) wasn't an issue I'd still not build a
publish a new version.
Given that I see little reason to merge this in master. If someone wants
to build their own version with app trigger support they can just just
clone your fork and use it.
------------------------------
Alternatively, I'd be happy to create a separate branch for this feature
on this repo and you can merge into that one. I'll remember to keep it in
sync with master if I ever come back to developing this.
I hope you understand. :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#27 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABPOQXPHJKIGPN476GF5IPTRUJDH7ANCNFSM4NPCQS2Q>
.
|
Just dropped by and wanted to say that you actually have (literally) a whole fanbase of at least 50 IT professionals and esports players - who use this small addon since its inception, across various CPU platforms that came along, trough all of the W10 iterations...up until now. :-) |
Hi, @MilanPutnik thanks for the kind words! I'll think about it :). |
This pull requests adds the functionality to switch power plans when an application starts or stops.
New configuration items have been added for:
Note that this functionality requires that the app be given administrator privileges.