Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle default case of spec.preemptible #116

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Handle default case of spec.preemptible #116

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd751cf
handle default value of preemptible flag
odp Apr 8, 2022
361a183
Merge branch 'master' into handle-def-spec
odp Apr 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sched/adaptdl_sched/allocator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ async def _allocate_one_loop(self):
# We only consider newly-added preemptible jobs
# because this allocation may not be final.
if (event["type"] == "ADDED" and
event["object"]["spec"]["preemptible"]):
event["object"]["spec"].get("preemptible", True)):
async with self._lock:
await self._allocate_one(event)

Expand Down