Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to add Python 3.7 support #196

Merged
merged 1 commit into from
Apr 3, 2019
Merged

Conversation

pfmoore
Copy link
Collaborator

@pfmoore pfmoore commented Jul 12, 2018

No description provided.

@pfmoore
Copy link
Collaborator Author

pfmoore commented Oct 2, 2018

Hi, this PR unpins psutil, allowing installs for Python 3.7 on Windows without needing a compiler (psutil don't provide binaries of old versions for new Pythons), as well as adding Python 3.7 to CI.

I had to drop Python 3.3 from the CI, as many of pew's dependencies have now dropped Python 3.3 support, and I wasn't sure how worthwhile it would be to chase all the dependencies down and pin them to older versions. If you need me to do that I probably can.

gnprice added a commit to gnprice/pew that referenced this pull request Nov 25, 2018
Python 3.3 reached EOL a couple of months ago, and setuptools dropped support
for it earlier this year: pypa/setuptools@7392f01ff . As a result, the 3.3 entry in the
build matrix has been erroring out since at least pew-org#196.
@pfmoore
Copy link
Collaborator Author

pfmoore commented Jan 21, 2019

@berdario ping...

@pfmoore
Copy link
Collaborator Author

pfmoore commented Apr 3, 2019

@berdario Another ping. Any chance of getting this merged?

@berdario berdario merged commit 814187c into pew-org:master Apr 3, 2019
@berdario
Copy link
Collaborator

berdario commented Apr 3, 2019

Merged!

Thanks a lot, and also for chasing...

triaging and working on Pew's contributions is on my todo list, but along with a bunch of other things it keeps getting pushed back. It's now 1 year since I last worked on Pew :/

Lots of things happened: a breakup, travelled to a new continent, change role/team/office and finally moved home...

I'm finally using Python again in my new team, though it's Bazel and vendoring, instead of setuptools and pip, so Pew won't see much use here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants