Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-created --venv venvs in the PEX_ROOT have bad paths. #1276

Closed
jsirois opened this issue Mar 17, 2021 · 0 comments · Fixed by #1278
Closed

Auto-created --venv venvs in the PEX_ROOT have bad paths. #1276

jsirois opened this issue Mar 17, 2021 · 0 comments · Fixed by #1278
Assignees
@jsirois
Labels
bug

Comments

@jsirois
Copy link
Member

jsirois commented Mar 17, 2021

For example, in the activate script:

$ grep VIRTUAL_ENV= /home/jsirois/.pex/venvs/58fcefe170c11af69bfde52b33ba6424ccb3260f/800ae8ef047bd783543e8282c22bfdbee7b7fca8/bin/activate 
VIRTUAL_ENV="/home/jsirois/.pex/venvs/58fcefe170c11af69bfde52b33ba6424ccb3260f/800ae8ef047bd783543e8282c22bfdbee7b7fca8.9c28554a8e4c4931a664c3d329088975"

The AtomicDirectory work_dir ends up embedded instead of the final resting target_dir:
https://github.com/pantsbuild/pex/blob/4619b107b1e6c37cfd98a1b0f43bb4f7a33d3945/pex/common.py#L309-L313
@jsirois jsirois added the bug label Mar 17, 2021
@jsirois jsirois self-assigned this Mar 17, 2021
jsirois added a commit to jsirois/pex that referenced this issue Mar 17, 2021
@jsirois
Re-structure atomic_directory.
cede900 
It now always yields the associated `AtomicDirectory` object to allow
callers complete access to the atomic directory state.

Work towards pex-tool#1276.
@jsirois jsirois mentioned this issue Mar 17, 2021
Merged
jsirois added a commit that referenced this issue Mar 17, 2021
@jsirois
Re-structure atomic_directory. (#1277)
431b543 
It now always yields the associated `AtomicDirectory` object to allow
callers complete access to the atomic directory state.

Work towards #1276.
jsirois added a commit to jsirois/pex that referenced this issue Mar 17, 2021
@jsirois
Fix auto-created --venv core scripts.
0488b1a 
Previously the `python-config` and various activation scripts had bad
paths embedded that prevented proper operation.

Fixes pex-tool#1276
@jsirois jsirois mentioned this issue Mar 17, 2021
Merged
jsirois added a commit that referenced this issue Mar 17, 2021
@jsirois
Fix auto-created --venv core scripts. (#1278)
0248455 
Previously the `python-config` and various activation scripts had bad
paths embedded that prevented proper operation.

Fixes #1276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsirois jsirois

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix auto-created --venv core scripts. jsirois/pex
1 participant
@jsirois