Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

later versions of setuptools add new wheel finders #309

Closed
wickman opened this issue Oct 28, 2016 · 0 comments
Closed

later versions of setuptools add new wheel finders #309

wickman opened this issue Oct 28, 2016 · 0 comments
Labels

Comments

@wickman
Copy link
Contributor

wickman commented Oct 28, 2016

yay! this may obviate the need for pex/finders.py, except now the following breaks:
https://github.com/pantsbuild/pex/blob/85ef56ad/pex/util.py#L93

the reason: now both the monkeypatched finder provided by pex and the new setuptools finder find a distribution in the pex cache, thus len(distributions) == 2 even though the distributions are identical. for whatever reason, pex throws up its hands and returns None instead, causing PEXEnvironment.update_candidate_distributions to barf.

i have no idea why the code was written the way it was (senility has crept in), but if you replace list() with set() in order to dedupe and return distributions.pop(), things work regardless of setuptools version.

@wickman wickman added the bug label Oct 28, 2016
lorencarvalho added a commit to lorencarvalho/pex that referenced this issue Nov 30, 2016
* master:
  Update README to reflect that linkedin's pygradle produces pex files (pex-tool#308)
  Release 1.1.15
  Fix pex-tool#309 by deduplicating output of the distribution finder. (pex-tool#310)
  Update wheel dependency to >0.26.0 (pex-tool#304)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant