Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PythonInterpreter should not need to be manually setup with vendored extras #632

Closed
jsirois opened this issue Dec 13, 2018 · 0 comments
Closed
Assignees

Comments

@jsirois
Copy link
Member

jsirois commented Dec 13, 2018

This shows up as a wart when pex is used as a library. Folks have to do this:

import pex
from pex.interpreter import PythonInterpreter


interpreter = pex.vendor.setup_interpreter(PythonInterpreter.get())

The vendor package is really not meant for public consumption, but populating interpreters with appropriate extras (setuptools & wheel) that pex has vendored for use with PEXBuilder should be automatic.

@jsirois jsirois self-assigned this Dec 13, 2018
@jsirois jsirois mentioned this issue Dec 13, 2018
jsirois added a commit to jsirois/pex that referenced this issue Dec 14, 2018
This is the single bit of pex build-time that needs interpreters setup
with extras. Encapsulate setup there where it's safe to rely on the
vendor package and simplify the pex API as a result as evidenced by test
simplification.

Fixes pex-tool#632
jsirois added a commit that referenced this issue Dec 15, 2018
This is the single bit of pex build-time that needs interpreters setup
with extras. Encapsulate setup there where it's safe to rely on the
vendor package and simplify the pex API as a result as evidenced by test
simplification.

Fixes #632
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant