-
-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guard against concurrent re-imports. #1270
Conversation
This can be tested in Pants via:
In step 2 you'd use I've attached the pex.zip file if you want to use the one I built using step 1. I had to rename it to |
Using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for getting to the bottom of this!
You're welcome, but the characterization is incorrect. This fix was the only one I could imagine given all reports / OSes / interpreters / logs, but it still has a logical hole. The fix only works if |
Although there is currently no identified way this can happen, this fix
is known to work for one victim of #1272.
Fixes #1272