Introduce the pex3 lock create command.
#1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides a basic platform specific lock generation facility. For now, the lock is only useful when a single platform or interpreter is selected by the target options. A follow-up will introduce a lock format that can store multiple locks allowing use and export of these as individual units. Work towards pex-tool#1401.
Eric-Arellano
approved these changes
Sep 21, 2021
Comment on lines
+53
to
+57
| "The style of lock to generate. The {strict!r} style is the default and generates " | ||
| "a lock file that contains exactly the distributions that would be used in a local " | ||
| "resolve. If an sdist would be used, the sdist is included, but if a wheel would " | ||
| "be used, an accompanying sdist will not be included. The {sources} style includes " | ||
| "locks containing wheels and the associated sdists when available.".format( |
There was a problem hiding this comment.
Will strict include wheels for other platforms? (pantsbuild/pants#12458)
I traced the code back to this and can't tell:
There was a problem hiding this comment.
There was a problem hiding this comment.
So, I mean, yes - it will include wheels for other platforms when --platform is specified. I assumed you meant though for all possible other platforms, i.e.: totally platform agnostic. That's #1402.
There was a problem hiding this comment.
Yeah I did mean #1402. Cool, thanks for clarifying!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a basic platform specific lock generation facility.
For now, the lock is only useful when a single platform or interpreter
is selected by the target options. A follow-up will introduce a lock
format that can store multiple locks allowing use and export of these
as individual units.
Work towards #1401.