Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #154 by storing profiling env var prior to env var deletion #162

Merged
merged 1 commit into from
Oct 9, 2015

Conversation

baroquebobcat
Copy link
Contributor

This causes the profile filename to be stored prior to cleaning the environment, just like how coverage manages it.

fixes #154

@baroquebobcat baroquebobcat changed the title Fix 154 by storing profiling env var prior to env var deletion Fix #154 by storing profiling env var prior to env var deletion Oct 2, 2015
@jsirois jsirois added this to the 1.1 milestone Oct 7, 2015
@jsirois
Copy link
Member

jsirois commented Oct 7, 2015

I've added this to the 1.1 release milestone. I'll be devoting this Friday 10/9 to getting this change in and that release released.

@baroquebobcat
Copy link
Contributor Author

Thanks!

@jsirois jsirois mentioned this pull request Oct 7, 2015
jsirois added a commit that referenced this pull request Oct 9, 2015
Fix #154 by storing profiling env var prior to env var deletion
@jsirois jsirois merged commit 8cc9ecd into pex-tool:master Oct 9, 2015
@jsirois
Copy link
Member

jsirois commented Oct 9, 2015

Thanks @baroquebobcat !

@baroquebobcat
Copy link
Contributor Author

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PEX_PROFILE_FILENAME not respected
2 participants