Fix artifact downloads for foreign platforms. #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the `ArtifactDownloader` to re-use the tricks used for `--style universal` locks to trick Pip into not rejecting artifacts that are not compatible with the current interpreter. FIxes pex-tool#1849
jsirois
added a commit
to jsirois/pex
that referenced
this pull request
Jul 13, 2022
benjyw
approved these changes
Jul 13, 2022
jsirois
added a commit
to jsirois/pex
that referenced
this pull request
Jul 14, 2022
Although pex-tool#1851 fixed Downloader to use a "universal" targetless download it left code in LockResolver that tracked targets laying about. Simplify now that target tracking is no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the
ArtifactDownloaderto re-use the tricks used for--style universallocks to trick Pip into not rejecting artifactsthat are not compatible with the current interpreter.
FIxes #1849