Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail on atomic_directory work_dir collision. #1905

Merged
merged 1 commit into from
Sep 11, 2022

Conversation

jsirois
Copy link
Member

@jsirois jsirois commented Sep 10, 2022

Previously, in the astronomically unlikely case that two (or more) attempts at creating an atomic directory collided on their UUID4-based work directory, the colliding attempts would all succeed and possibly lead to a corrupt final target directory. Now work directory creation fails loudly when the work directory already exists. Re-try of the Pex command will ~always work in this case but we'll have a paper trail of a UUID4 collision.

Fixes #1901

@jsirois jsirois mentioned this pull request Sep 10, 2022
2 tasks
@jsirois jsirois merged commit b21dec0 into pex-tool:main Sep 11, 2022
@jsirois jsirois deleted the issues/1901 branch September 11, 2022 01:00
Previously, in the astronomically unlikely case that two (or more)
attempts at creating an atomic directory collided on their UUID4-based
work directory, the colliding attempts would all succeed and possibly
lead to a corrupt final target directory. Now work directory creation
fails loudly when the work directory already exists. Re-try of the Pex
command will ~always work in this case but we'll have a paper trail of
a UUID4 collision.

Fixes pex-tool#1901
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AtomicDirectory masks UUID4 collisions
2 participants