Fail on atomic_directory work_dir collision. #1905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjyw
approved these changes
Sep 10, 2022
Previously, in the astronomically unlikely case that two (or more) attempts at creating an atomic directory collided on their UUID4-based work directory, the colliding attempts would all succeed and possibly lead to a corrupt final target directory. Now work directory creation fails loudly when the work directory already exists. Re-try of the Pex command will ~always work in this case but we'll have a paper trail of a UUID4 collision. Fixes pex-tool#1901
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, in the astronomically unlikely case that two (or more) attempts at creating an atomic directory collided on their UUID4-based work directory, the colliding attempts would all succeed and possibly lead to a corrupt final target directory. Now work directory creation fails loudly when the work directory already exists. Re-try of the Pex command will ~always work in this case but we'll have a paper trail of a UUID4 collision.
Fixes #1901