Introduce --non-hermetic-venv-scripts.
#2068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides the same option when building a PEX as the `--non-hermetic-scripts` does when creating a venv from a PEX using `pex-tools`. In addition, both means of creating a non-hermetic venv are extended to the venv `pex` script itself. Closes pex-tool#2065
jsirois
commented
Feb 25, 2023
| # type: (Any) -> None | ||
|
|
||
| # A console script that injects an element in the PYTHONPATH. | ||
| ot_simulator_src = os.path.join(str(tmpdir), "src") |
There was a problem hiding this comment.
As named, this simulates OpenTelemetry auto-instrumentation - actually turning the manual test detailed here #2065 (comment) into an IT seemed too fragile / likely flaky.
jsirois
commented
Feb 25, 2023
| @@ -190,7 +191,12 @@ def create_sh_boot_script( | |||
| # interpreter to use is embedded in the shebang of our venv pex script; so just | |||
| # execute that script directly. | |||
| export PEX="$0" | |||
| exec "${{INSTALLED_PEX}}/bin/python" -sE "${{INSTALLED_PEX}}" "$@" | |||
There was a problem hiding this comment.
I had missed this 1 spot. That's the last.
benjyw
approved these changes
Feb 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides the same option when building a PEX as the
--non-hermetic-scriptsdoes when creating a venv from a PEX usingpex-tools. In addition, both means of creating a non-hermetic venvare extended to the venv
pexscript itself.Closes #2065