Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --pip overrides via PEX deps. #2107

Merged
merged 3 commits into from
Mar 30, 2023
Merged

Conversation

jsirois
Copy link
Member

@jsirois jsirois commented Mar 28, 2023

Now, when creating a venv using pex tools and the --pip option from a
PEX that includes pip or setuptools or both, those embedded versions
will be used in place of the conflicting versions installed via --pip
if --collisions-ok is also specified; otherwise the venv pex tool will
error.

Closes #2105

@jsirois jsirois marked this pull request as ready for review March 30, 2023 18:45
@jsirois jsirois requested a review from cognifloyd March 30, 2023 18:45
@jsirois jsirois mentioned this pull request Mar 30, 2023
2 tasks
@jsirois jsirois requested a review from benjyw March 30, 2023 21:05
Copy link

@cognifloyd cognifloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me. Thanks!

@jsirois jsirois merged commit 7aa0a15 into pex-tool:main Mar 30, 2023
@jsirois jsirois deleted the issues/2105 branch March 30, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature(pex.tools): prefer a pex-file-provided package versions when --pip flag is also provided
3 participants