Factor out configured resolves from pex.
#2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code as well as selection of a unique target to resolve for will be re-used by the forthcoming `pex3 venv create` command. Along the way, clean up confusion noted in pex-tool#2135 in the introduction of the `pex3 venv` subcommand surrounding `pyvenv.cfg` files generated by `Virtualenv`. Work towards pex-tool#1752 and pex-tool#2110.
|
This is a 2-moves and a comment grab-bag to consolidate CI and make the final |
cognifloyd
approved these changes
Apr 28, 2023
zmanji
approved these changes
Apr 28, 2023
kaos
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code as well as selection of a unique target to resolve for will be
re-used by the forthcoming
pex3 venv createcommand.Along the way, clean up confusion noted in #2135 in the introduction of
the
pex3 venvsub-command surroundingpyvenv.cfgfiles generated byVirtualenv.Work towards #1752 and #2110.