Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add official support for Python 3.12 / Pip 23.2. #2176

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

jsirois
Copy link
Member

@jsirois jsirois commented Jul 20, 2023

Pip 23.2 is both the latest release and the only release that supports
Python 3.12.

The Pip 23.2 release notes are here:
https://pip.pypa.io/en/stable/news/#v23-2

Fixes #2173

def test_sdist_for_project_with_pep517_build(tmpdir):
# type: (Any) -> None
assert_create_and_use_sdist_lock(tmpdir, "PyYAML==5.4.1", "import yaml")
assert_create_and_use_sdist_lock(tmpdir, "PyYAML==6.0.1", "import yaml")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsirois jsirois changed the title Add support for Python 3.12 / Pip 23.2. Add official support for Python 3.12 / Pip 23.2. Jul 20, 2023
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Would it make sense to remove any of the functionality like hidden - less code complexity? I imagine it's useful to keep for Python 3.13.

@jsirois
Copy link
Member Author

jsirois commented Jul 20, 2023

Would it make sense to remove any of the functionality like hidden - less code complexity? I imagine it's useful to keep for Python 3.13.

It will be useful - maybe - for 3.13, but it will definitely be useful to support tracking Pip HEAD in CI which I plan to do to get early warning of breaks: #2177

@jsirois jsirois merged commit 62829bd into pex-tool:main Jul 20, 2023
@jsirois jsirois deleted the issues/2173 branch July 20, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove PipVersion 23.2.dev0+xyz and replace with Pip 23.2
3 participants