Fix third_party.exposed().
#2330
Conversation
This cleans up pex-tool#2328 by fixing the root cause of the interpreter identification leak of exposed `attrs`. The API to report exposed `sys.path` elements, `third_party.exposed()`, worked at build time, with a full Pex distribution available, but returned an empty iterator at run time, with the subset of Pex available in the runtime `.bootstrap/`.
| return False | ||
|
|
||
| sys_path = OrderedSet(entry for entry in sys.path if entry and not is_internal_entry(entry)) | ||
| sys_path = OrderedSet( |
There was a problem hiding this comment.
This is the simpler check that existed pre-#2328. It was always the right check; it's just that third_party.exposed() was broken at PEX runtime.
There was a problem hiding this comment.
And all is well here. Performing this change 1st led to a failing test_boot_identification_leak test, and then fixing below got that passing again.
| for importer in cls._iter_all_installed_vendor_importers(): | ||
| # All Importables for a given VendorImporter will have the same prefix. | ||
| if importer._importables and importer._importables[0].prefix == prefix: | ||
| if importer._root == root: | ||
| if {importable.path for importable in importer._importables} == vendored_paths: | ||
| yield importer | ||
| yield importer |
There was a problem hiding this comment.
This comparison of the vendored paths at runtime (from the PEX .bootstrap/) would always fail since Pex only vendors a subset of all available vendored distributions in the runtime bootstrap of a PEX. The vendored Pip, for one, is never vendored in the runtime; it is only used at build time.
I'm not sure why I added this check in the 1st place back in #624 when I introduced vendoring / the pex.third_party import hook. Checking the root and prefix is enough to ensure the discovered VendorImporter is the one in question.
|
The setuptools build backend introduced to handle pre-testing Python 3.13 in CI is quite flaky. Yet another instance: https://github.com/pantsbuild/pex/actions/runs/7545643289/job/20541741101?pr=2330#step:5:1847 I'm working on switching the build system in a separate PR to handle dynamic |
Fix in #2331 |
This cleans up #2328 by fixing the root cause of the interpreter
identification leak of exposed
attrs. The API to report exposedsys.pathelements,third_party.exposed(), worked at build time,with a full Pex distribution available, but returned an empty iterator
at run time, with the subset of Pex available in the runtime
.bootstrap/.