Lock sdists in more cases for foreign platforms. #2508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when locking for a foreign platform and only an sdist was available, the lock would fail if the sdist's build backend did not support the `prepare_metadata_for_build_wheel` PEP-517 hook and this resulted in building a wheel that was platform specific and incompatible with the foreign platform. Now, we grab the METADATA from the incompatile wheel under the same motivation we do so for `--style universal` locks: in general, the only sane thing to do is assume metadata is consistent across all the distributions for a given project release (even though we know this is not always true in the wild (PyTorch)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when locking for a foreign platform and only an sdist was
available, the lock would fail if the sdist's build backend did not
support the
prepare_metadata_for_build_wheelPEP-517 hook and thisresulted in building a wheel that was platform specific and incompatible
with the foreign platform. Now, we grab the METADATA from the
incompatible wheel under the same motivation we do so for
--style universallocks: in general, the only sane thing to do isassume metadata is consistent across all the distributions for a given
project release (even though we know this is not always true in the
wild; e.g.: PyTorch).