Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add User-Agent header when resolving via urllib #663

Merged
merged 2 commits into from
Feb 6, 2019

Conversation

AndrewLvov
Copy link
Contributor

@AndrewLvov AndrewLvov commented Feb 5, 2019

At least some Python Index servers return a simple format of packages page, redirecting to / to /+simple/.

So there is a different result between pex run using urllib and using requests - in one case it errors.

Copy link
Member

@jsirois jsirois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AndrewLvov! A bit of cleanup and I'll be happy to merge this.

pex/http.py Outdated Show resolved Hide resolved
pex/http.py Outdated Show resolved Hide resolved
@jsirois jsirois merged commit fe405f9 into pex-tool:master Feb 6, 2019
@jsirois jsirois mentioned this pull request Feb 6, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants