Revendor pip #890
Merged
Revendor pip #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New version is still a patched 20.0.dev0, with a new patch to fix a performance issue. Fixes pex-tool#887.
|
The first commit is human-edited and reviewable. The second is just the result of running |
Eric-Arellano
approved these changes
Feb 14, 2020
cosmicexplorer
approved these changes
Feb 14, 2020
|
|
||
| # We shell out to pip at buildtime to resolve and install dependencies. | ||
| # N.B.: This is pip 20.0.dev0 with a patch to support foreign download targets more fully. | ||
| yield VendorSpec.vcs('git+https://github.com/pantsbuild/pip@5eb9470c0c59#egg=pip', rewrite=False) |
There was a problem hiding this comment.
This is really cool!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version is still a patched 20.0.dev0, with a new patch
to fix a performance issue.
Fixes #887