Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise exception on 503 error #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Raise exception on 503 error #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions meetup/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,8 @@ def _call(self, service_name, parameters=None, **kwargs):
raise exceptions.HttpUnauthorized
if response.status_code == 404:
raise exceptions.HttpNotFoundError
if response.status_code == 503:
raise exceptions.HttpServerError
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exceptions.HttpServerError is a base class for 5xx errors, not meant to be raised directly; similar to exceptions.HttpClientError.

If we are to raise an exception for 5xx, create a new class (based from HttpServerError), then raise that.


# If we have two or less remaining calls in the period, wait (if the wait flag is set).
# I tried only waiting after a 429 error, and ended getting locked out doing parallel testing.
Expand Down