Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type annotations #10

Closed
layday opened this issue Jun 25, 2021 · 2 comments
Closed

Type annotations #10

layday opened this issue Jun 25, 2021 · 2 comments

Comments

@layday
Copy link

layday commented Jun 25, 2021 •
edited
Loading

Would annotating the public API be a welcome addition? I would only be adding type annotations in a PR - I won't be touching any of this project's infrastructure, e.g. to get mypy running in CI.
@pfmoore
Copy link
Owner

pfmoore commented Jun 25, 2021

Yes, it would. I've not done much with type annotations, but I'd be happy to get them added. I'll happily handle adding the infrastructure side of things.

layday added a commit to layday/editables that referenced this issue Jun 25, 2021
@layday
Annotate the public API
377662b 
Closes pfmoore#10.
@pfmoore
Copy link
Owner

pfmoore commented Jun 29, 2023

Added in #14

@pfmoore pfmoore closed this as completed Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pfmoore @layday