Add new handler get-logins-by-names #227
Open
+123
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 3, 2014 22:02
Fixed get-logins-all to actually do what it says in its name, rather than a unpredictable subset due to incorrect regular expression use, and also added get-logins-by-names, to allow returning of multiple non-linked credentials.
Conflicts: KeePassHttp.plgx KeePassHttp/KeePassHttp.cs latest-version.txt update-version.txt
…ecompiling pglx and removing some unnecessary changes, so that it is hopefully ready for a pull request.
ScottDennison
changed the title
ScottDennison
changed the title
|
thanks, I finally reviewed this, and it looks good to go, please rebase and remove the committed plgx file |
|
I have had a look at #233 and noticed that it's comitter added code that I am missing in my new handler and probably should have (for the allow dialog, and things like sorting). Would you prefer that these were added before I went ahead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As well as being a useful tool for helping with browser based logins, KeePass+KeePassHTTP could also be a useful tool for retrieving username/passwords for use in programs, instead of hardcoding credentials into them. However, for this use case, accessing entries by URL is not very helpful, instead it is better to access by name/title. It is also feasible that multiple entries will be needed by a single program.
This pull requests adds support for a new request type 'get-logins-by-names', where a list of names (encrypted in the same way as other request strings), instead of a URL, is provided.
At some point in the future, I will also upload to github, the java class library that I wrote to uses get-logins-by-names to retrieve entries.