Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine pfio.cache.HTTPCache #293

Merged
merged 6 commits into from
Dec 20, 2022
Merged

Refine pfio.cache.HTTPCache #293

merged 6 commits into from
Dec 20, 2022

Conversation

y1r
Copy link
Member

@y1r y1r commented Dec 19, 2022

This PR refines HTTPCache to support fault-tolerance and multiprocessing with fork-server execution model.

  • 8ab92df
    • Reports error (i.e. unexpected HTTP status code or exception) to user instead of stop working
  • 36b1df8
    • We can expect that the HTTP backend doesn't return many redirect or errors, so we limit the number of retries to one.
  • b138d89
    • We can expect that the HTTP backend processes requests faster I/O, so we shorten the timeout.
  • 72c9da4
    • multiprocessing with fork-server execution model requires picklable parameters. The connection pool doesn't support pickle so we re-create the pool if we detected the fork.

@y1r
Copy link
Member Author

y1r commented Dec 19, 2022

/test

@pfn-ci-bot
Copy link

Successfully created a job for commit 72c9da4:

1 similar comment
@pfn-ci-bot
Copy link

Successfully created a job for commit 72c9da4:

@y1r
Copy link
Member Author

y1r commented Dec 19, 2022

/test

@pfn-ci-bot
Copy link

Successfully created a job for commit 957ea2f:

1 similar comment
@pfn-ci-bot
Copy link

Successfully created a job for commit 957ea2f:

@kuenishi kuenishi added this to the 2.5.0 milestone Dec 20, 2022
@kuenishi
Copy link
Member

kuenishi commented Dec 20, 2022

@y1r I've fixed the main CI at #295 (just removed flake8), so please rebase and test this pull request again.

@kuenishi kuenishi self-requested a review December 20, 2022 03:06
@y1r y1r force-pushed the refine-httpcache branch from 957ea2f to e995632 Compare December 20, 2022 03:16
@y1r
Copy link
Member Author

y1r commented Dec 20, 2022

/test

@pfn-ci-bot
Copy link

Successfully created a job for commit e995632:

1 similar comment
@pfn-ci-bot
Copy link

Successfully created a job for commit e995632:

@y1r
Copy link
Member Author

y1r commented Dec 20, 2022

/test

@pfn-ci-bot
Copy link

Successfully created a job for commit 42a8e16:

1 similar comment
@pfn-ci-bot
Copy link

Successfully created a job for commit 42a8e16:

@kuenishi kuenishi merged commit 06d11b3 into pfnet:master Dec 20, 2022
@y1r y1r deleted the refine-httpcache branch December 20, 2022 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants