Merging a fork #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very solid rewrite. 👍 merging. |
sammacbeth
pushed a commit
to sammacbeth/dat-gateway
that referenced
this pull request
Apr 9, 2018
feat: coveralls
sammacbeth
pushed a commit
to sammacbeth/dat-gateway
that referenced
this pull request
Sep 1, 2018
* added websocket peers test * added axios to tests (supports promises) * removed setTimeout * commented out console.log * removed the new Promise, since axios supports Promises * added socket.end inside the socket.on * added Promise and delay to 'feed' test * added error handler for getWebsocketHandler stream issue pfrazee#4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges my fork into your repo. I refactored the code, added testing, dat-dns resolution, and a cache for archives. You can see a demo here: https://dat.bovid.space/garbados.hashbase.io/icons/favicon.ico
I recognize this PR represents considerable changes so I intend it as a WIP branch with the goal of being merged.