Automatically update apinger to dpinger #105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the Service Watchdog watch list. Forum: https://forum.pfsense.org/index.php?topic=109770.msg611158#msg611158 Doing it here means that people will get the automatic change as soon as they upgrade to 2.3 and the upgrade installs the Service Watchdog code from here. The other place it could be done is in upgrade_config.inc - but then that will not be distributed to them until pfSense 2.3.1 happens - rather too late.
| // apinger became dpinger in pfSense 2.3 | ||
| if ($svc['name'] == 'apinger') { | ||
| $a_pwservices[$idx]['name'] = $svc['name'] = 'dpinger'; | ||
| write_config(gettext("Service Watchdog updated service apinger to dpinger")); |
There was a problem hiding this comment.
I like the idea of this fix, but I don't like doing a write_config here. Even if it only triggers once, it's not an ideal place.
It could assume by apinger they meant dpinger without the save, perhaps fixing it permanently next time they make a save in the GUI.
There was a problem hiding this comment.
I made PR #106 which has the simplified version without write_config() - take your pick.
netgate-git-updates
pushed a commit
that referenced
this pull request
Apr 14, 2016
when processing the Service Watchdog list. Leave the permanent update of the list for when the user next edits Service Watchdog settings. This is an alternate version of #105
netgate-git-updates
pushed a commit
that referenced
this pull request
Apr 14, 2016
when processing the Service Watchdog list. Leave the permanent update of the list for when the user next edits Service Watchdog settings. This is an alternate version of #105
|
Closing in favor of #106 |
netgate-git-updates
pushed a commit
that referenced
this pull request
Jun 15, 2020
Build now explicitly requires gmake per https://github.com/yaml/libyaml/releases/tag/0.2.5 the following changes have been made - #105 Allow question marks in plain scalars in flow collections - #186 Emitter: Don't output trailing space for empty scalar nodes - #185 Emitter: Output space after an alias mapping key - #187 Add -h and --flow (on|off|keep) to run-*-test-suite - #182 Remove unnecessary include and malloc - #177 Add specific files back to .gitignore - #181 Output error position in run-parser-test-suite.c - #191 A couple patches to improve test suite support - #179 Flow indicators can not be part of local or shorthand tags PR: 247043 Submitted by: daniel.engberg.lists@pyret.net
netgate-git-updates
pushed a commit
that referenced
this pull request
May 21, 2022
ChangeLog: General Removed DataTables from everywhere (see #107) Backup job report Fixed a bug while displaying compression ratio for canceled jobs (see #105) Client report Fixed SQL query error using custom datetime format in Client report page (see #106) Fixed bug(s) 105 [bug] - Division by zero with canceled jobs inBackup Job report 106 [bug] - SQL query error using custom datetime format in Client report page 107 [improvement] - Remove datatables dependency and related code 108 [bug] - Broken job status link in last period job status New feature(s) none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the Service Watchdog watch list.
Forum: https://forum.pfsense.org/index.php?topic=109770.msg611158#msg611158
Doing it here means that people will get the automatic change as soon as they upgrade to 2.3 and the upgrade installs the Service Watchdog code from here. The other place it could be done is in upgrade_config.inc - but then that will not be distributed to them until pfSense 2.3.1 happens - rather too late.