Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security/pfSense-pkg-acme: add dns_googledomains #1247

Closed
wants to merge 1 commit into from

Conversation

heitbaum
Copy link

Add support for Google Domains DNS API

ref: https://domains.google/learn/gts-acme/

This is an ACME API for Google Domains customers, which is different from the Google Cloud Domains API for Google Cloud customers.

There are 2 competing upstream PRs for this support, once available in upstream (and the ENV variable ratified) this can be pulled in.

The PRs are:

Add support for Google Domains DNS API

ref: https://domains.google/learn/gts-acme/

This is an ACME API for Google Domains customers, which is
different from the Google Cloud Domains API for Google Cloud
customers.

Supported by https://github.com/acmesh-official/acme.sh
PR 4542
@heitbaum
Copy link
Author

Upstream acme dns_google domains has been accepted - acmesh-official/acme.sh#4542

@jim-p
Copy link
Contributor

jim-p commented Mar 27, 2023

To effectively track changes and bug/feature requests, we require an entry on the pfSense Redmine issue tracker associated with every pull request, and likewise the Redmine entry should also have a link back to the pull request.

Please associate this PR to a Redmine issue either by locating an existing issue at https://redmine.pfsense.org or by creating a new issue. Add a link to the Redmine issue that points to this PR, and also add a link on the PR to the Redmine issue.

For more information, see https://docs.netgate.com/pfsense/en/latest/development/pull-request.html
Thanks!

@jim-p
Copy link
Contributor

jim-p commented Mar 27, 2023

After it's all merged into upstream I will need to do a resync with upstream before merging this PR.

@ionothanus
Copy link

Upstream is merged. Is this the relevant Redmine issue? https://redmine.pfsense.org/issues/9200

@jim-p
Copy link
Contributor

jim-p commented Jun 9, 2023

I'm handling this manually as a part of a package update. No need for a PR.

@jim-p jim-p closed this Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants