Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSoC 2022: Manas Sivakumar Week 2 #219

Merged
merged 9 commits into from
Jun 26, 2022

Conversation

Manas23601
Copy link

@Manas23601 Manas23601 commented Jun 21, 2022

Changes Proposed in this Pull Request:

  • vrp_knapsack SQL function.
  • placeholders for vrp_knapsack doc, docqueries and src.
  • Configured Cmake to process OR-Tools functions.

@Manas23601 Manas23601 self-assigned this Jun 21, 2022
@Manas23601 Manas23601 added the manas-2022 Done by Manas Sivakumar label Jun 21, 2022
@Manas23601 Manas23601 removed their assignment Jun 21, 2022
@Manas23601
Copy link
Author

Manas23601 commented Jun 21, 2022

How do I stop Github actions from running build each and every time I push some changes ?

@Manas23601
Copy link
Author

I think I have created a basic skeleton(still incomplete) for now. If there are problems, please let me know. Please direct me to any resources if necessary

@Manas23601 Manas23601 requested review from krashish8 and removed request for krashish8 June 21, 2022 14:51
@krashish8
Copy link
Member

How do I stop Github actions from running build each and every time I push some changes?

I don't think you should do that. It's good to see the Actions result after every push. Initially, they are going to fail.
Anyway, if you want, you can temporarily disable the corresponding actions in the Actions tab for your fork, or can comment the corresponding workflow file.

@krashish8
Copy link
Member

@Manas23601 Maybe it's a good idea to reconsider the naming of the functions or the directory structure.
You can probably ask in the pgRouting Gitter channel for the same.

I think you should only use underscores in the function name, not dashes. Some function names suggestions:

  • vrp_or_knapsack_0_1
  • vrp_or_knapsack
  • vrp_knapsack_0_1 (OR stands for Operations Research tools, but it may mislead the users sometimes)
  • vrp_knapsack
  • vrp_knapsack_01

The directory could be knapsack only, or or_tools or something related, but not knapsack_0-1.

@cvvergara
Copy link
Member

I am wondering, is there a knapsack that is not 0-1?
For the moment in vrpRouting the answer is NO.
vrp_knapsack I prefer as the name, and if in there future there is another kind of knapsack we will figure out the name

@Manas23601
Copy link
Author

I will immediately look at the name changes. I think I forgot to commit those changes

@Manas23601 Manas23601 self-assigned this Jun 26, 2022
@Manas23601 Manas23601 marked this pull request as ready for review June 26, 2022 17:30
@Manas23601 Manas23601 merged commit 44648ae into pgRouting:manas-2022 Jun 26, 2022
@Manas23601 Manas23601 changed the title Manas week 2 GSoC 2022: Manas Sivakumar Week 2 Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
manas-2022 Done by Manas Sivakumar
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants