GSoC 2023: Aryan Gupta Week 2 #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvvergara
reviewed
Jun 11, 2023
| @@ -9,3 +9,6 @@ src/version/version.h | |||
| .directory | |||
| notUsed | |||
| *.swp | |||
|
|
|||
There was a problem hiding this comment.
cvvergara
reviewed
Jun 11, 2023
| @@ -11,19 +11,19 @@ UPDATE edges AS edge_table | |||
| SET node_count=count.sum | |||
There was a problem hiding this comment.
Please do not update result files unless things work 100%
cvvergara
reviewed
Jun 11, 2023
| ; | ||
| ERROR: invalid reference to FROM-clause entry for table "edges" | ||
| LINE 14: WHERE edges.source=count.from_v | ||
| LINE 14: WHERE edges.source=count.start_vid |
There was a problem hiding this comment.
Clearly there is something wrong.
Is it an original issue from the pgRouting repo?
If it is, then there is something wrong with the original. aka someone, probably me, did what you are doing without really looking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Changes proposed in this pull request:
-Added the extra column start_vid to the single vertex
-Renamed the from_vid to start_vid for multiple vertices
-Fixed the pgtap testcases
-Changed the docqueries accordingly
@pgRouting/admins