-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pgr_maxCardinalityMatch fix #2344
Merged
cvvergara
merged 14 commits into
pgRouting:develop
from
cvvergara:maxCardinalityMatch-enhancement
Jul 8, 2022
Merged
pgr_maxCardinalityMatch fix #2344
cvvergara
merged 14 commits into
pgRouting:develop
from
cvvergara:maxCardinalityMatch-enhancement
Jul 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvvergara
changed the title
Max cardinality match enhancement
pgr_maxCardinalityMatch enhancement
Jun 30, 2022
cvvergara
changed the title
pgr_maxCardinalityMatch enhancement
pgr_maxCardinalityMatch fix
Jun 30, 2022
cvvergara
requested review from
cayetanobv,
dkastl,
krashish8,
robe2 and
omshinde
June 30, 2022 17:39
omshinde
approved these changes
Jul 1, 2022
Need to wait until I backport to master all the documentation before merging changes to current functions. |
robe2
approved these changes
Jul 2, 2022
cvvergara
force-pushed
the
maxCardinalityMatch-enhancement
branch
from
July 7, 2022 15:14
a93cf07
to
a4ee9a1
Compare
* Ignoring directed flag * Accepting cost & reverse cost on the inner query * Works only for undirected graphs
* Adding new signature * Deprecating signature with directed as parameter
* tests with cost & reverse cost * tests with & without directed flag * kept all deprecated tests
* On function example * On how to migrate
cvvergara
force-pushed
the
maxCardinalityMatch-enhancement
branch
from
July 8, 2022 16:39
60f4835
to
3c17e63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2342
Changes proposed in this pull request:
pgr_maxcardinalitymatch(text)
returnsedge
pgr_maxcardinalitymatch(text,boolean)
cost
&reverse_cost
on the inner queryChanges on these directories
Additional "unrelated" changes
For some reason the script to update the locale on the action is not working for weblate (works for transifex)
locale
directory updated manuallyThe check_queries action fail is confusing when the signature file is not updated
@pgRouting/admins