Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table_spec): fix incorrect delete stmt generation with both LIMIT and RETURNING #19

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

pga2rn
Copy link
Owner

@pga2rn pga2rn commented Aug 2, 2024

Introduction

This PR fixes table_spec.table_delete_stmt API generating incorrect sql stmt when using both LIMIT and RETURNING, see the correct graph at chapter 3 at https://www.sqlite.org/lang_delete.html.

Copy link

github-actions bot commented Aug 2, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/simple_sqlite3_orm
   __init__.py70100% 
   _orm.py2322688%43, 45–46, 49–50, 148, 402, 447, 529, 531–532, 541–542, 544, 582, 605, 648, 679, 681–682, 691–692, 694, 729, 758, 813
   _sqlite_spec.py360100% 
   _table_spec.py1712187%45, 60, 69, 80, 84–85, 97, 109, 126, 187, 192–194, 270, 272, 274–275, 333–334, 443–444
   _types.py19194%27
   _utils.py51590%52, 65, 68, 78, 91
   utils.py971782%112, 119–120, 155–158, 204, 217, 237–241, 267, 271, 312
TOTAL6137088% 

Tests Skipped Failures Errors Time
60 0 💤 0 ❌ 0 🔥 2m 3s ⏱️

Copy link

sonarcloud bot commented Aug 2, 2024

@pga2rn pga2rn added the bug Something isn't working label Aug 2, 2024
@pga2rn pga2rn merged commit 3036606 into main Aug 2, 2024
12 checks passed
@pga2rn pga2rn deleted the fix/returning_stmt branch August 2, 2024 16:08
Bodong-Yang added a commit to tier4/ota-client that referenced this pull request Aug 2, 2024
Bumps simple-sqlite3-orm to v0.2.1.

Upstream fixes a problem related to using both RETURNING and LIMIT in DELETE stmt, see pga2rn/simple-sqlite3-orm#19 for more details.

Bumps the version fixes otaproxy not working on ubuntu 22.04 and newer.
Bodong-Yang added a commit to tier4/ota-client that referenced this pull request Aug 2, 2024
Bumps simple-sqlite3-orm to v0.2.1.

Upstream fixes a problem related to using both RETURNING and LIMIT in DELETE stmt, see pga2rn/simple-sqlite3-orm#19 for more details.

Bumps the version fixes otaproxy not working on ubuntu 22.04 and newer.
Bodong-Yang added a commit to tier4/ota-client that referenced this pull request Aug 7, 2024
Bumps simple-sqlite3-orm to v0.2.1.

Upstream fixes a problem related to using both RETURNING and LIMIT in DELETE stmt, see pga2rn/simple-sqlite3-orm#19 for more details.

Bumps the version fixes otaproxy not working on ubuntu 22.04 and newer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant