Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(e2e): do not use limit on delete test as SQLITE_ENABLE_UPDATE_DELETE_LIMIT compile flag is not enabled by default #69

Merged
merged 3 commits into from
Dec 30, 2024

Conversation

pga2rn
Copy link
Owner

@pga2rn pga2rn commented Dec 30, 2024

This fixes tests on windows as seems like SQLITE_ENABLE_UPDATE_DELETE_LIMIT is not enabled(not enabled by default, see https://www.sqlite.org/compile.html) on sqlite3 libs with python distribution on windows.

Other changes: now set as OS Independent in pyproject.toml.

@pga2rn pga2rn added chore invalid This doesn't seem right test_files Update to test files and removed invalid This doesn't seem right labels Dec 30, 2024
Copy link

github-actions bot commented Dec 30, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/simple_sqlite3_orm
   __init__.py12375%28–30
   _sqlite_spec.py360100% 
   _table_spec.py1883481%49, 58, 69, 73–74, 86, 98, 176, 181–183, 223, 304, 306, 308–309, 357, 360, 364–366, 368–372, 374, 380, 423–424, 534–535, 549–550
   _types.py24195%34
   _utils.py751185%40, 42–43, 46–47, 69, 84, 87, 97, 110, 134
   utils.py1243670%127, 134–135, 170–173, 219, 232, 252–256, 282, 286, 333, 338–345, 357–359, 361–362, 365, 367–369, 378–379
src/simple_sqlite3_orm/_orm
   __init__.py40100% 
   _async.py91990%28, 70, 72–73, 86–87, 89, 124, 126
   _base.py1221389%98, 149, 171–173, 186–188, 287, 327, 409, 449, 472
   _multi_thread.py1031090%28, 30–31, 66, 68–69, 82–83, 85, 118
   _utils.py18288%18, 40
TOTAL79711985% 

Tests Skipped Failures Errors Time
78 0 💤 0 ❌ 0 🔥 1m 56s ⏱️

@pga2rn pga2rn enabled auto-merge (squash) December 30, 2024 11:59
@pga2rn pga2rn merged commit d5e4ad8 into main Dec 30, 2024
15 checks passed
@pga2rn pga2rn deleted the chore/fix_test_on_windows branch December 30, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore test_files Update to test files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant