Triage Aurora utility statement I/O stats issue #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes a bug where un-EXPLAIN-able query samples were dropped entirely when using log-based EXPLAIN.
These are bogus right now due to Aurora bugs, so zero them out to avoid distorting our graphs.
lfittl
approved these changes
Dec 31, 2020
lfittl
added a commit
that referenced
this pull request
Jun 28, 2022
Relevant changes that apply to the collector: - Fixes memory leak in pg_query_fingerprint error handling [#141](pganalyze/libpg_query#141) - Add support for parsing more operators that include a `?` character (special cased to support old pg_stat_statements query texts) - ltree extension [#136](pganalyze/libpg_query#136) - promscale extension [#133](pganalyze/libpg_query#133)
lfittl
added a commit
that referenced
this pull request
Jun 29, 2022
Relevant changes that apply to the collector: - Fixes memory leak in pg_query_fingerprint error handling [#141](pganalyze/libpg_query#141) - Add support for parsing more operators that include a `?` character (special cased to support old pg_stat_statements query texts) - ltree extension [#136](pganalyze/libpg_query#136) - promscale extension [#133](pganalyze/libpg_query#133)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are bogus right now due to Aurora bugs, so zero them out to avoid distorting our graphs.
Strictly speaking, I think we've only seen
blk_read_timeandblk_write_timebeing off,but it's probably prudent to ignore all of them(we've reviewed the other stats and feel it's better to only ignore timing, since that may be handled as an Aurora extension whereas other stats are likely straight from Postgres). Also, since these are not nullable, I'm instead zeroing them out. I think this is better than the impossibly huge values we're seeing now, but let me know if you think we should approach this differently.