Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistent test failure #618

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Fix inconsistent test failure #618

merged 1 commit into from
Oct 18, 2024

Conversation

seanlinsley
Copy link
Member

@seanlinsley seanlinsley commented Oct 17, 2024 •
edited
Loading

Followup to #607, this should fix the inconsistent test failure we're seeing by moving the output string generation after its array is sorted by the test.

--- FAIL: TestAnalyzeStreamInGroups (0.01s)
    stream_test.go:390: For zero
        first
        second
        third
        : log state diff: (-want +got)
        -"zero\nfirst\nsecond\nthird\n"
        +"third\nzero\nfirst\nsecond\n"
FAIL

@seanlinsley seanlinsley requested a review from a team October 17, 2024 13:50
@seanlinsley seanlinsley merged commit 6d2ed61 into main Oct 18, 2024
9 checks passed
@seanlinsley seanlinsley deleted the stream-test-fix branch October 18, 2024 00:25
@seanlinsley seanlinsley mentioned this pull request Nov 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keiko713 keiko713 keiko713 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seanlinsley @keiko713