Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify SHA256 checksum of downloaded libpg_query #178

Merged
merged 2 commits into from
Dec 27, 2020

Conversation

stanhu
Copy link
Contributor

@stanhu stanhu commented Dec 4, 2020

This guards against any malicious attempts to change the archive.

Also use URI.open to get rid of this Ruby 2.7 warning:

warning: calling URI.open via Kernel#open is deprecated, call URI.open
directly or use URI#open

This guards against any malicious attempts to change the archive.

Also use `URI.open` to get rid of this Ruby 2.7 warning:

```
warning: calling URI.open via Kernel#open is deprecated, call URI.open
directly or use URI#open
```
@lfittl
Copy link
Member

lfittl commented Dec 27, 2020

@stanhu Good idea - thanks for the contribution!

(I've also added the sha256sum to the libpg_query release, for easier reference: https://github.com/lfittl/libpg_query/releases/tag/10-1.0.3)

@lfittl lfittl merged commit 64c6cad into pganalyze:master Dec 27, 2020
@stanhu stanhu mentioned this pull request Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants