Use official upstream release + patches, remove flex/bison dependency #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mme This should resolve the Heroku deployment issues for you :) |
|
Alright, this is basically ready to merge, but still a fairly substantial change to how the build works. @JackDanger could you also give this branch a try to make sure it doesn't break hsql? Much appreciated! :) |
lfittl
added a commit
that referenced
this pull request
Oct 16, 2015
Use official upstream release + patches, remove flex/bison dependency
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a long time pg_query has been using a forked version of upstream, with two patches applied:
?replacement charactersThis PR changes this to using an actual upstream release (latest on 9.4 branch) + patches, which has the added benefit that we no longer require flex/bison to be installed (since the release ships with pre-generated files).
Fixes #31.