Patches for 4.39.22801 #128
Comments
packages
FS kobo11 21908 -> kobo11 22801
FS kobo11 22801 -> kobo12 22801
qrc 21908 -> 22801
libnickel strings 21908 -> 22801
libnickel symbols 21908 -> 22801
see #128 (comment) |
|
Resource extraction: go run github.com/pgaskin/qrc/cmd/qrc2zip@latest --output nickel.21908.qInitResources_styles.zip --recursive --verbose nickel 1 26762560 26622584 26750920
go run github.com/pgaskin/qrc/cmd/qrc2zip@latest --output nickel.21908.qInitResources_resources.zip --recursive --verbose nickel 1 21737592 101096 21736112
go run github.com/pgaskin/qrc/cmd/qrc2zip@latest --output nickel.21908.qInitResources_certificates.zip --recursive --verbose nickel 1 26923968 26765808 26919792
go run github.com/pgaskin/qrc/cmd/qrc2zip@latest --output nickel.21908.qInitResources_translations.zip --recursive --verbose nickel 1 26622256 21738816 26621512https://krc.storage.pgaskin.net/nickel.21908.qInitResources_certificates.zip |
|
@pgaskin I don't see 4.39 on your fw page. How do I get a copy? |
|
I'll be adding it once I figure out which device is which, and whether the Tolino install instructions are the same. |
|
OK. |
|
Update: Do not install this firmware on older devices until I look into a few things. I found some stuff which may cause nickel to fail to start correctly. |
|
I don't need to actually install 4.39 to be able to make some progress. I just need to be able to extract |
|
I'm going to start figuring out which device is which, then I'll take a break until this evening (~5h) since there's some other stuff I need to do. I don't plan to release the patches for this version until next week at the earliest, even if they're done. I think we should probably support Tolino, put a note that it's not fully tested, and put comments in the patches which are for only tolino/kobo (I don't think there should bee to many of those). |
|
I should be able to have a good look at nickel in 5 hours. I may not still be awake by the time you resume but I'll add some notes here if there's anything worth saying. 😄 |
|
The 4 patchable files seem to be identical in mark11 and mark12. That's a good thing isn't it? |
|
Yep |
|
0x1624760
|
libnickel 21908 -> 22801
|
|
Throughout nickel CSS:
Based on changes in So far, these are the only nickel patch changes I've had to make to get kobopatch to run without error. Whether the patches still do what they're supposed to do is another matter! ATM I'm not sure what the best way to support Tolino might be. The change re Tolino and font Bariol is repeated very many times in nickel CSS. Every hard-coding of However some I'm glad we've got some extra time available before having to release 4.39 patches. |
Yes, kobo seems to have revamped the fonts in general (see my earlier content).
Main thing to look for is tolino overrides in the same CSS file.
For patches which change the font, remove the tolino override. For patches which don't, add another option to replace that.
Yeah, tolino seems to use a larger font size by default for many things, including the dictionary. I'll need to look at bariol to figure out whether Kobo thinks German users have impaired vision, or if bariol just looks smaller at the same size. I think for now, we should just replace it with the Kobo value by removing the tolino override in the font size patches. |
A bunch more than usual, some expected, most easy, but some will be annoying to update. Will need to pay extra attention when updating things in places near tolino-specific code. |
|
I think I already fixed these 4: although the last two will need a patch name change due to 'Amasis' & 'Gill Sans' no longer being relevant. I'll need to test these two quite carefully once I've got a device I can safely update. |
|
The included Bariol font is locked but it (or a version of it) seems to be freely available via the web. It's a sans-serif font with "rounded ends". Quite nice, if a little "thin". Slightly worrisome that the web versions are double the filesize of the Kobo versions so I don't know how good glyph coverage will be. |
|
|
Mostly finished looking at firmware changes.
|
How does this work if Georgia and Avenir are no longer listed in fw fonts? |
I'm not exactly sure, but this is one of the things I noticed which caused me to change my mind about compatibility with older devices for this update. I also just tried installing it on my Aura2Ev1 (from 21908), and it's bootlooping. I plan to figure out why, but I'm going to finish the patch updates first. |
Missing: - "Default ePub serif/sans-serif font" needs to be rewritten since the font is an arg now. - "Custom page navigation scrubber" needs css updates. - "Customise Header back button" needs css updates. - "My 24 line spacing values" may need major changes. - "Allow rotation on all devices" needs to be looked at. - "Customize ComfortLight settings" may need to be rewritten or have multiple offset changes. Also need to: - Check if other CSS patches need updates for tolino compatibility. - Check if PDF-related patches need a comment or special-casing for foxit. - Check smartlink stuff. - Add comments to patches which will not have an effect on tolino readers due to feature removal. - Maybe write more patches. See #128 (comment).
|
Affiliates can still overwrite it. |
No-one knows what it's supposed to do or whether it works. #128
Default serif font seems to have changed from Georgia to 'Rakuten Serif'. Amasis font no longer in fw. #128
Default sans-serif font seems to have changed to 'Rakuten Sans'. 'Gill Sans' font no longer included in fw. #128
|
@pgaskin My recent commit for update to patch |
|
@pgaskin Having spent more time looking at all the changes, this is my current plan for your consideration:
ETA: 4.39 doesn't seem to distinguish between Tolino Shine and Tolino Vision for font-size. It's literally one-size-fits-all. |
The new Tolino with Kobo firmware will only release at the beginning of May, but I'd be happy to help testing, as well as translating some stuff. |
Thanks very much for volunteering 😄 Which Tolino model do you (or will you) have? Are you contactable via MobileRead or just here at GitHub? |
Just GitHub so far, but I'll sign up on MobileRead later. I'm planning to order a shine color. I'm also active on some German tolino forums (I was previously modding & reverse engineering the older Tolinos) and can probably get some people on there to test too,also on the older models once/if Tolino starts switching from Android to Kobo's OS (They're preparing that in their beta firmware, although I don't have up-to-date builds to see how far they got). |
I've been watching some of the YouTube early review videos. Looking at the HomeScreen and Tabs it looks like the sans-serif font used on the Tabs may be Bariol. So maybe DefaultSansSerif is also Bariol, even on Kobos? [ETA: Hmm. Just seen a different video and now I'm not so sure. I wonder if the review devices have different fws depending on how long ago the reviewer received it?] Also, if the version of Bariol I found on the internet is similar to what will be shipped in Kobo fw I think you can stop worrying about German users and possible impaired vision. 😄 It's simply a font which displays much smaller at the same font-size than something like Georgia or Caecilia. |
Seems to be |
Haven't seen you for ages. Have you got a secret new project? 😄 Yes, the shared product id caused a minor kerfuffle for the calibre driver. Hopefully querying the On a different colour-related subject ... ages ago you shared some calibre code to maximise the quality of grayscale thumbnails/screensavers. Do you have any thoughts about potential for improving colour equivalents? |
Nah, IRL just got busier than expected ;).
Ah. Didn't expect people to have already gotten their hands on some and bothered calibre with it, should have checked that. Yeah, assuming they don't reintroduce something like what happened in 4.35 with devices sharing a PCB IDs (which appears to be the case for the B&W/Color pairs...), the Nickel version tag ought to be accurate. |
That's going to be annoying, yeah. I suspect we'll need to blow up saturation like crazy (which probably explains why they started shipping openCV). The only prior experience with this I've had is on PocketBook, where if you don't let InkView (the PB middleware) pre-process the images, you end up with a pretty underwhelming result (not that it's particularly great when you do, but I digress... ;p). The good news is that, as far as calibre is concerned, this should be a non-issue, as I expect Nickel to be doing that on-device, and, IIRC, the driver has a setting that lets Nickel generates all the thumbnails (or did I dream that one up?). |
I think "people" is restricted to a single Libra Colour user who accidentally received their new toy ridiculously early. Unless it all happened via PM they didn't appear to be particularly helpful in supplying useful info but they did go so far as to say that their device connected successfully to calibre using the incomplete beta driver. I hope the updated driver will be OK for all 3 devices. Time will tell. |
The calibre KOBOTOUCH driver lets users choose whether or not to let calibre create and send all the correctly-sized thumbnails/screensavers (Colour vs. B&W, pre-optimised grayscale or not, pre-letterboxed or not). But I think you wrote most of that. 😄 My memory is that you felt quite strongly, at the time, that it was better to let calibre do as much of the B&W image manipulation as possible rather than leaving it all up to the Kobo. I really hope that's true, if not I've misrepresented you on MR in the last few days. 😊 To the best of my knowledge the following is true ... if the user opts to not let calibre send all the thumbnails then the device extracts the page 1 cover as the basis for creating all the required thumbnails. They are only created as required, so if you page through the booklist it can be a slow process populating the GUI with images after the initial book transfer. Are you saying that with colour it might be better to let the Kobo do all the image manipulation work itself? |
Yup. Nickel got better at it over the years, but for B&W, I still stand by that (i.e., properly dithered B&W PNGs).
Yup; it's not terrible on modern devices, though.
That's what I expect, yeah. We'll have to see how it actually fares, but I have very low expectations of the Kaleido tech without heavily pre-processed images from what I've seen on PB ;p. |
Or, well, the actual cover (as per ePub 2/3 metadata) for properly authored books. I don't remember if what happens otherwise (or for PDFs) as a fallback is the "render page 1" option, or just "create a synthetic text cover" (which is something that does happen as a placeholder during thumbnail generation, at least). |
|
I just did some quick tests. You're probably right that the actual cover is extracted from kepub, if it's found, but if not, page 1 is extracted. For standard epub it's always extracted as a rendering of page 1, no matter whether it's epub2 or epub3, even if the epub3 has the correct |
|
And now we have to fix NickelHook too... |
|
My Libre Colour showed up today. Only thing I have loaded on it right now is NickleClock (works no problems) so let me know if you need anything off of it to help |
|
hey all! i've been keeping up some local manually edited copies of kobopatch for the two new firmwares (.39.22801 and .22861), I don't have everything 100% working but if it would be helpful I could open a branch with my mods on it, or else help commit some updates here? |
|
There's some WIP stuff in here. The details of what needs to be done are here. I still need to look at 4.39.22861 as well. Feel free to open PRs for each patch you've updated for 22801 if it hasn't already been done, and I'll take a look. We are currently very busy with other things, but I hope to get the patches updated and released sometime in the next week or two, then I'll be working on NickelMenu. |
|
Update: I've been busy for the last month, but I hope to get to this on the weekend if I have time. |
The text was updated successfully, but these errors were encountered: