-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kepub constant font sharpness #116
base: master
Are you sure you want to change the base?
Kepub constant font sharpness #116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This one looks safe enough to backport as long as the automated tests pass, so feel free to do so if you want. Otherwise, I'll probably do it after merging.
FYI, also note that you can safely remove the last semicolon in a CSS block, which could give you another character of space here.
src/versions/4.34.20097/libnickel.so.1.0.0.yaml/superjeng1.yaml
Outdated
Show resolved
Hide resolved
Yeah, I am aware of that, I don't really think one would want that level of precision so I didn't do it. I would make the change anyways. Also, I found that you could actually make the value more than |
Ok, I would check how far it backports to, but I don't think I would be running every version on my device myself though. |
In
libnickel.so.1.0.0.yaml/geoffr.yaml
, constant font sharpness patch is missing for KePubs. He left a comment in the file which reads:I don't quite understand it since I am able to do the patch and verify that it is actually working with screenshots. Have I missed anything? Also, I only edited version 4.34 and 4.35 because I have only tested these versions.