Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kepub constant font sharpness #116

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

superjeng1
Copy link

In libnickel.so.1.0.0.yaml/geoffr.yaml, constant font sharpness patch is missing for KePubs. He left a comment in the file which reads:

MISSING: KePub constant font sharpness (not enough room for neutralizing the QString arg; we will probably need to patch that one out)

I don't quite understand it since I am able to do the patch and verify that it is actually working with screenshots. Have I missed anything? Also, I only edited version 4.34 and 4.35 because I have only tested these versions.

@pgaskin pgaskin removed the request for review from geoffreynolds December 31, 2022 04:50
@pgaskin pgaskin added enhancement Type: Improvement (but not a new patch or update). patches Category: Relates to the patches. css Tag: A nickel CSS patch. labels Dec 31, 2022
Copy link
Owner

@pgaskin pgaskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This one looks safe enough to backport as long as the automated tests pass, so feel free to do so if you want. Otherwise, I'll probably do it after merging.

FYI, also note that you can safely remove the last semicolon in a CSS block, which could give you another character of space here.

@superjeng1
Copy link
Author

FYI, also note that you can safely remove the last semicolon in a CSS block, which could give you another character of space here.

Yeah, I am aware of that, I don't really think one would want that level of precision so I didn't do it. I would make the change anyways.

Also, I found that you could actually make the value more than 0.2 and it would still make a difference, but it would start eating away the actual font though. I would update the description for this discovery too.

@superjeng1
Copy link
Author

This one looks safe enough to backport as long as the automated tests pass, so feel free to do so if you want.

Ok, I would check how far it backports to, but I don't think I would be running every version on my device myself though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css Tag: A nickel CSS patch. enhancement Type: Improvement (but not a new patch or update). patches Category: Relates to the patches.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants