Implemented sendMultiple() method to send multiple messages with 1 API call #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 12, 2018 20:51
…() and testParametersSend().
…sage->getMailJetMessage().
…ADME.md (composer require command, config fix, note for running the tests).
…e->getMailJetMessage().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented the
sendMultiple()method in theMailerclass following the convention ofBaseMailer(but added an optional$returnResponseparameter to return the API's response, as that is handy when errors occur while sending multiple mails at once.I added a
getMailJetMessage()method to Message to build an array that represents the Message object as the MailJet API expects it.I also added 2 tests for the new
sendMultiple()method, everything passes (using PHPUnit).Also updated the README accordingly.
No backwards-compatibility breaking changes were made.
It's only my second PR, so let me know if I should change anything.
Thanks for the nice component.