Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect explanation in doc [Improvement] #3

Closed
vineryap opened this issue Feb 21, 2023 · 1 comment
Closed

Incorrect explanation in doc [Improvement] #3

vineryap opened this issue Feb 21, 2023 · 1 comment

Comments

@vineryap
Copy link

Note that bigm_similarity is NOT case-sensitive, but pg_trgm's similarity function is case-sensitive. should be Note that bigm_similarity IS case-sensitive, but pg_trgm is not.
https://github.com/pgbigm/pg_bigm/blob/master/html/pg_bigm_en-1-2.html#L379

Cheers!
MasaoFujii added a commit that referenced this issue Mar 24, 2023
@MasaoFujii
Correct documentation for bigm_similarity to indicate case-sensitivity.
702ee35 
The previous documentation for bigm_similarity incorrectly stated that
it was not case-sensitive. This commit updates the documentation to
reflect that bigm_similarity IS case-sensitive.

Please note that the Japanese version of the documentation is not updated
as it already accurately explains bigm_similarity and its case-sensitivity.

Back-patch to pg_bigm 1.1.

Reported and suggested by: Vin Yap
Discussion: #3
MasaoFujii added a commit that referenced this issue Mar 24, 2023
@MasaoFujii
Correct documentation for bigm_similarity to indicate case-sensitivity.
d0dc347 
The previous documentation for bigm_similarity incorrectly stated that
it was not case-sensitive. This commit updates the documentation to
reflect that bigm_similarity IS case-sensitive.

Please note that the Japanese version of the documentation is not updated
as it already accurately explains bigm_similarity and its case-sensitivity.

Back-patch to pg_bigm 1.1.

Reported and suggested by: Vin Yap
Discussion: #3
MasaoFujii added a commit that referenced this issue Mar 24, 2023
@MasaoFujii
Correct documentation for bigm_similarity to indicate case-sensitivity.
24702db 
The previous documentation for bigm_similarity incorrectly stated that
it was not case-sensitive. This commit updates the documentation to
reflect that bigm_similarity IS case-sensitive.

Please note that the Japanese version of the documentation is not updated
as it already accurately explains bigm_similarity and its case-sensitivity.

Back-patch to pg_bigm 1.1.

Reported and suggested by: Vin Yap
Discussion: #3
@MasaoFujii
Copy link
Member

@vineryap
Thanks for the report and suggestion!
I pushed the docs fix.
24702db

@robert-pang robert-pang mentioned this issue Apr 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MasaoFujii @vineryap