Fix memory allocation bug in bigm_gin.c. #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, pg_bigm allocated only a single byte (sizeof(bool)) for extra_data, an output argument used to pass additional data from gin_extract_query_bigm() to gin_bigm_consistent() and gin_bigm_triconsistent(). However, extra_data must be allocated as an array with a pointer for each key. This misallocation could lead to a segmentation fault. This commit fixes the issue by ensuring gin_extract_query_bigm() properly allocates memory for the required number of key pointers in extra_data. Reported-by: Robert Pang Reported-by: howladr
|
Thank you for creating a PR to fix this issue. The fix looks good to me. |
MasaoFujii
added a commit
that referenced
this pull request
Feb 25, 2025
Previously, pg_bigm allocated only a single byte (sizeof(bool)) for extra_data, an output argument used to pass additional data from gin_extract_query_bigm() to gin_bigm_consistent() and gin_bigm_triconsistent(). However, extra_data must be allocated as an array with a pointer for each key. This misallocation could lead to a segmentation fault. This commit fixes the issue by ensuring gin_extract_query_bigm() properly allocates memory for the required number of key pointers in extra_data. Back-patch to pg_bigm 1.0 where this bug exists. Reported-by: Robert Pang (@robert-pang) Reported-by: howladr (@howladr) Reviewed-by: Robert Pang (@robert-pang) Reviewed-by: howladr (@howladr) Reviewed-by: Masahiko Sawada (@MasahikoSawada)
MasaoFujii
added a commit
that referenced
this pull request
Feb 25, 2025
Previously, pg_bigm allocated only a single byte (sizeof(bool)) for extra_data, an output argument used to pass additional data from gin_extract_query_bigm() to gin_bigm_consistent() and gin_bigm_triconsistent(). However, extra_data must be allocated as an array with a pointer for each key. This misallocation could lead to a segmentation fault. This commit fixes the issue by ensuring gin_extract_query_bigm() properly allocates memory for the required number of key pointers in extra_data. Back-patch to pg_bigm 1.0 where this bug exists. Reported-by: Robert Pang (@robert-pang) Reported-by: howladr (@howladr) Reviewed-by: Robert Pang (@robert-pang) Reviewed-by: howladr (@howladr) Reviewed-by: Masahiko Sawada (@MasahikoSawada)
MasaoFujii
added a commit
that referenced
this pull request
Feb 25, 2025
Previously, pg_bigm allocated only a single byte (sizeof(bool)) for extra_data, an output argument used to pass additional data from gin_extract_query_bigm() to gin_bigm_consistent() and gin_bigm_triconsistent(). However, extra_data must be allocated as an array with a pointer for each key. This misallocation could lead to a segmentation fault. This commit fixes the issue by ensuring gin_extract_query_bigm() properly allocates memory for the required number of key pointers in extra_data. Back-patch to pg_bigm 1.0 where this bug exists. Reported-by: Robert Pang (@robert-pang) Reported-by: howladr (@howladr) Reviewed-by: Robert Pang (@robert-pang) Reviewed-by: howladr (@howladr) Reviewed-by: Masahiko Sawada (@MasahikoSawada)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, pg_bigm allocated only a single byte (sizeof(bool)) for extra_data, an output argument used to pass additional data from gin_extract_query_bigm() to gin_bigm_consistent() and gin_bigm_triconsistent(). However, extra_data must be allocated as an array with a pointer for each key. This misallocation could lead to a segmentation fault.
This commit fixes the issue by ensuring gin_extract_query_bigm() properly allocates memory for the required number of key pointers in extra_data.
Reported-by: Robert Pang
Reported-by: howladr
Discussion: #9