Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSS Auth Implementation #1209

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

AndrewJackson2020
Copy link
Contributor

This PR implements GSS authentication in pgbouncer. This is a very important institutional feature that allows a client to verify its identity to a server (and vice versa) without the client ever sending its password to the server.

Since the underlying gss c functions are network blocking and synchronous I used the threaded design common to the PAM implementation and the LDAP PR #731 use for this functionality. For the CI and testing aspects of this PR I found the GSS backend encryption PR #743 helpful as well.

Sources:

@AndrewJackson2020 AndrewJackson2020 changed the title GSS Implementation GSS Auth Implementation Nov 18, 2024
doc/config.md Outdated Show resolved Hide resolved
@JelteF
Copy link
Member

JelteF commented Dec 2, 2024

Just as with the LDAP PR it would be very helpful if someone that uses GSS could try this PR out. I can do a review to see if the code looks sensible, but I don't really know enough about GSS to do an indepth review of this (nor do I have the time to learn).

@JelteF
Copy link
Member

JelteF commented Dec 3, 2024

FYI while cleaning up old PRs I found this one: #441

It would probably be good to check if there are any good ideas in there.

@AndrewJackson2020
Copy link
Contributor Author

FYI while cleaning up old PRs I found this one: #441

It would probably be good to check if there are any good ideas in there.

I did see that. Definitely took some ideas from that in terms of how to interact with the GSS API from it.

@AndrewJackson2020
Copy link
Contributor Author

AndrewJackson2020 commented Dec 4, 2024

Expanded the test coverage and feature set. Tried to match all of the GSS options that are available in postgres (case insensitive match, realm match, etc). I believe that I have everything covered currently with the exception of user mapping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants