Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include bindings for controlfile #1320

Merged

Conversation

feikesteenbergen
Copy link
Contributor

@feikesteenbergen feikesteenbergen commented Oct 5, 2023

NOTE: I didn't include the updated generated bindings, as I'm still unsure as to what the proper invocation is, these still need to be generated.

The function get_controlfile is very useful for some monitoring experiments and solutions.

I'm working on a bgworker that starts even when in crash recovery. Part of the goal of this worker is to provide more insight into the progress of crash recovery:

  • distance to consistency (in WAL bytes)
  • distance since last checkpoint (in WAL bytes)

For that to work nicely, it would be great to have access to the get_controlfile function, which exposes this information in an easy digestable fashion.

@feikesteenbergen feikesteenbergen force-pushed the feike/controlfile branch 3 times, most recently from 12a3f06 to 1b9e0d1 Compare October 10, 2023 07:48
@feikesteenbergen
Copy link
Contributor Author

I'm not sure what I'm doing wrong, tests locally work, and this seems to fail all the time against postgres-16 only.

@eeeebbbbrrrr
Copy link
Contributor

This CI failure is our fault. It’s on my list to resolve today, actually.

Thanks and hang tight!

@eeeebbbbrrrr eeeebbbbrrrr mentioned this pull request Oct 10, 2023
@eeeebbbbrrrr
Copy link
Contributor

I fixed CI in the develop branch. If you want to rebase this and push again, we should see things be all green here.

I'd kinda like for this PR to be green before we merge since it's related to bindings generation.

I plan on cutting a v0.10.x later this week, and I'm happy to cherry-pick this PR once we merge it into develop.

The function get_controlfile is very useful for some monitoring
experiments and solutions.
@eeeebbbbrrrr eeeebbbbrrrr merged commit c2eac03 into pgcentralfoundation:develop Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants