Allow most low-info clippy warnings #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many clippy warnings are not very informative or are unlikely to be usefully fixed any time soon. Allow them so that the remainder which constitute a problem actually stand out and can be fixed.
workingjubilee
commented
Nov 30, 2023
| clippy::missing_safety_doc, | ||
| clippy::too_many_arguments, | ||
| clippy::type_complexity, | ||
| clippy::unnecessary_cast |
There was a problem hiding this comment.
We just have way too many cases of "unnecessary casts", due to constant refactoring of some gnarly casts, to bother linting on this.
| @@ -7,6 +7,7 @@ | |||
| //LICENSE All rights reserved. | |||
| //LICENSE | |||
| //LICENSE Use of this source code is governed by the MIT license that can be found in the LICENSE file. | |||
| #![allow(clippy::assign_op_pattern)] | |||
There was a problem hiding this comment.
This is the entire point of this example, Clippy...
| clippy::len_without_is_empty, | ||
| clippy::missing_safety_doc, | ||
| clippy::too_many_arguments, | ||
| clippy::type_complexity, |
There was a problem hiding this comment.
This happens basically whenever you have a callback function in your arguments.
|
https://www.youtube.com/watch?v=Kvnwnf9UftA With this and the upcoming branch I'm working on, pgrx-sql-entity-graph is clippy-clean on stable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many clippy warnings are not very informative or are unlikely to be usefully fixed any time soon. Allow them so that the remainder which constitute a problem actually stand out and can be fixed.