Fixes wrong value for microsecs in a day #1849
Merged
+22
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YohDeadfall
reviewed
Sep 10, 2024
pgrx/src/datum/time_with_timezone.rs
Outdated
| @@ -24,7 +24,10 @@ use std::panic::{RefUnwindSafe, UnwindSafe}; | |||
| #[derive(Debug, Copy, Clone)] | |||
| #[repr(transparent)] | |||
| pub struct TimeWithTimeZone(pg_sys::TimeTzADT); | |||
| const MICROSECONDS_PER_DAY: pg_sys::TimeADT = 86_400_000; | |||
|
|
|||
| // 86_400_000_000 | |||
There was a problem hiding this comment.
Thanks for the fix! Could you mention that it comes from the USECS_PER_DAY constant?
There was a problem hiding this comment.
Makes sense, let's reuse that const across datetime module.
|
Thanks @aykut-bozkurt. Could you add a test for this in the pgrx-tests crate? I believe there’s a module for date/time tests already. |
YohDeadfall
reviewed
Sep 10, 2024
| @@ -24,6 +24,9 @@ mod ops; | |||
|
|
|||
| pub use ctor::*; | |||
|
|
|||
| pub const USECS_PER_SEC: i64 = 1_000_000; | |||
| pub const USECS_PER_DAY: i64 = pg_sys::SECS_PER_DAY as i64 * USECS_PER_SEC; | |||
There was a problem hiding this comment.
@eeeebbbbrrrr, why does pg_sys has SECS_PER_DAY generated but not USECS_PER_SEC?
There was a problem hiding this comment.
hmm. Probably b/c of how it's defined in timestamp.h:
#define USECS_PER_SEC INT64CONST(1000000)Kinda doubt bindgen can see through even that simple of a #define.
|
I was very tired that week. |
daamien
pushed a commit
to daamien/pgrx
that referenced
this pull request
Sep 12, 2024
`MICROSECONDS_PER_DAY` constant at `time_with_timezone.rs` misses 3 additional zeros for microseconds part. That breaks conversion from `(pg_sys::TimeADT, i32)` to `TimeWithTimeZone`. Fixes pgcentralfoundation#1850
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MICROSECONDS_PER_DAYconstant attime_with_timezone.rsmisses 3 additional zeros for microseconds part.That breaks conversion from
(pg_sys::TimeADT, i32)toTimeWithTimeZone.Fixes #1850